Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131558 / 25.04 / Change observable subscription for apps widget #11172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RehanY147
Copy link
Contributor

Changes:

Changes how we get the subscription observable in the component

Testing:

Install two apps. plex and photoprism. Go to the dashboard. Add a widget for photoprism. Large widget for the app overview. Then without saving, open the add widget form again and add another widget for the same app.

Problem:
The stats data doesn't load the second time

Fix:
The stats load every time

@RehanY147 RehanY147 requested a review from a team as a code owner December 12, 2024 03:25
@RehanY147 RehanY147 requested review from undsoft and removed request for a team December 12, 2024 03:25
@bugclerk bugclerk changed the title NAS-131558: Change observable subscription for apps widget NAS-131558 / 25.04 / Change observable subscription for apps widget Dec 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (ecba8b5) to head (3aa9e5f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11172   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files        1652     1652           
  Lines       58334    58337    +3     
  Branches     5998     5998           
=======================================
+ Hits        48237    48240    +3     
  Misses      10097    10097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants