Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix): Remove tf.json filetype from terraform #945

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

TylerJang27
Copy link
Collaborator

Fixes #941. Verified repro with terraform and tofu format on x.tf.json files. Did a bit of research as well to make sure our other security scanners don't scan .tf.json files, and we should be fine.

Copy link

trunk-io bot commented Dec 30, 2024

⏱️ 42m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 21m 🟩
Linter Tests macOS 18m 🟩
Trunk Check runner [linux] 1m 🟩
CodeQL-Build 1m 🟩
Repo Tests / Plugin Tests 32s 🟩
Detect changed files 4s 🟩
Aggregate Test Results 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review December 30, 2024 21:36
Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@TylerJang27 TylerJang27 requested a review from det December 30, 2024 22:12
Copy link

trunk-io bot commented Dec 30, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Contributor

@det det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TylerJang27 TylerJang27 merged commit cc08b6f into main Dec 30, 2024
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/tf-json-filetype branch December 30, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Terraform + Tofu Plugins Bug: terraform fmt + tofu fmt erroneously run against **.tf.json files
2 participants