Skip to content

Commit

Permalink
feat: make LFS checkout optional (#260)
Browse files Browse the repository at this point in the history
Adds the option to disable LFS checkout either from services or as an
input.

Also, updates the registry for the docker image because docker tests
were failing with permission issues

Tested manually - tests here are failing for unrelated reasons.
  • Loading branch information
puzzler7 authored Sep 27, 2024
1 parent 5008e79 commit 12da16f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker_repo_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
# This is a docker image that mimics the github runner image
# https://github.com/catthehacker/docker_images/pkgs/container/ubuntu
container: catthehacker/ubuntu:runner-20.04
container: ghcr.io/catthehacker/ubuntu:runner-20.04
strategy:
fail-fast: false
matrix:
Expand Down
17 changes: 15 additions & 2 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ inputs:
required: false
default: false

lfs-checkout:
description: Option to checkout LFS files
required: false
default: true

runs:
using: composite
steps:
Expand All @@ -124,9 +129,15 @@ runs:
GITHUB_TOKEN=${{ github.token }}
EOF
# First arg is field to fetch, second arg is default value or empty
payload() {
if [ $# -lt 2 ]; then
DEFAULT_VALUE=empty
else
DEFAULT_VALUE=\"$2\"
fi
if command -v jq >/dev/null; then
jq -r ".inputs.payload | fromjson | .$1 // empty" ${TEST_GITHUB_EVENT_PATH:-${GITHUB_EVENT_PATH}}
jq -r ".inputs.payload | fromjson | .$1 // ${DEFAULT_VALUE}" ${TEST_GITHUB_EVENT_PATH:-${GITHUB_EVENT_PATH}}
else
echo "::error::jq not installed on system!"
exit 1
Expand Down Expand Up @@ -174,6 +185,7 @@ runs:
INPUT_UPLOAD_SERIES=$(payload uploadSeries)
INPUT_UPLOAD_ID=$(payload uploadId)
INPUT_AUTOFIX_AND_PUSH=$(payload autofixAndPush)
INPUT_LFS_CHECKOUT=$(payload lfsCheckout true)
EOF
else
Expand Down Expand Up @@ -208,6 +220,7 @@ runs:
INPUT_UPLOAD_SERIES=${{ inputs.upload-series }}
INPUT_UPLOAD_ID=
INPUT_AUTOFIX_AND_PUSH=
INPUT_LFS_CHECKOUT=${{ inputs.lfs-checkout }}
EOF
fi
Expand All @@ -216,7 +229,7 @@ runs:
if: env.INPUT_TARGET_CHECKOUT
uses: actions/checkout@v3
with:
lfs: true
lfs: ${{ env.INPUT_LFS_CHECKOUT && inputs.lfs-checkout }}
submodules: recursive
repository: ${{ env.INPUT_TARGET_CHECKOUT }}
ref: ${{ env.INPUT_TARGET_CHECKOUT_REF }}
Expand Down

0 comments on commit 12da16f

Please sign in to comment.