Dev space resample #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccuetom
reviewed
Dec 18, 2023
ccuetom
requested changes
Jan 15, 2024
| shot.wavelets = shot.wavelets._resample(factor=old_step/new_step, new_num=new_num) # resample wavelet | ||
| shot.observed = shot.observed._resample(factor=old_step/new_step, new_num=new_num) # resample observed | ||
|
|
||
| shot.wavelets = shot.wavelets._resample( # resample wavelet |
There was a problem hiding this comment.
if resample is an in-place operation then you don't need to assign the result, only call the method
ccuetom
requested changes
May 10, 2024
| try: | ||
| del self.__dict__['grid'] | ||
| except: |
There was a problem hiding this comment.
you've creared a _clear_cache method below, why are you not using it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resampling ultility functions implemented, I still have to test that everything is working as expected (i.e. no rounding errors)