Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Turkish more precisely #439

Closed
wants to merge 7 commits into from
Closed

Translate Turkish more precisely #439

wants to merge 7 commits into from

Conversation

berkaygunduzz
Copy link
Contributor

Changes

Made these translations more accurate based on real time usage:

  • in_app_feedback__description
  • mood
  • focus
  • relax
  • intensity
  • intensity_description
  • dense
  • light

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #439 (966378c) into master (fce3314) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files          32       32           
  Lines        1784     1784           
  Branches      227      227           
=======================================
  Hits         1524     1524           
  Misses        119      119           
  Partials      141      141           
Flag Coverage Δ
android 84.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce3314...abf4495. Read the comment docs.

@ashutoshgngwr
Copy link
Member

Is this ready to review and merge or do you need to make more changes?

@berkaygunduzz
Copy link
Contributor Author

That's it. For now there is no more chages.

@berkaygunduzz
Copy link
Contributor Author

Btw, how can i know that you added new strings in the future?

@ashutoshgngwr
Copy link
Member

@berkaygunduzz Okay. Regardless, I am going to leave this open until tomorrow in case you decide to add something.

PS, we track translation related changes in #200 for now.

@berkaygunduzz
Copy link
Contributor Author

Ok, thaks.

@berkaygunduzz
Copy link
Contributor Author

Do you want me to do translation more native (more like regular language) rather than official (like goverment official language)? It's more like official now.

@ashutoshgngwr
Copy link
Member

  1. How different is native from official? Are we talking about the same language but different phrases (or PS dialects)?
  2. If they are different, which one is more preferred by the people?

@berkaygunduzz
Copy link
Contributor Author

berkaygunduzz commented Dec 8, 2020

  • It's same language. But native uses idioms, figurative meanings etc. while official uses clear, simple language.
  • Native is more for projects that want to make their project more candid and friendly for users, official is more for projects that want to make their project more serious and professional for users.

@ashutoshgngwr
Copy link
Member

@berkaygunduzz I guess official is fine then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants