Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(browser terminal): overwrite ClientOptions with url query params #1333

Closed
wants to merge 0 commits into from
Closed

change(browser terminal): overwrite ClientOptions with url query params #1333

wants to merge 0 commits into from

Conversation

cangzhang
Copy link
Contributor

@cangzhang cangzhang commented Mar 25, 2024 •
edited
Loading

#1270

This PR enables ttyd to read ClientOption settings from url and overwrite server configuration.

Here is a working demo:

03-25.at.22.03.17.mp4

@cangzhang cangzhang marked this pull request as ready for review March 25, 2024 14:06
@cangzhang cangzhang mentioned this pull request Mar 25, 2024
Closed
@tsl0922
Copy link
Owner

tsl0922 commented Mar 25, 2024 •
edited
Loading

The value defined in App.tsx is default value, it can still be overwritten by Client Options from the server side.

@cangzhang cangzhang changed the title change(browser terminal): read query param for disableLeaveAlert from url change(browser terminal): overwrite ClientOptions with url query params Mar 25, 2024
@cangzhang
Copy link
Contributor Author

cangzhang commented Mar 25, 2024 •
edited
Loading

Update:

  • Added support for the following options:
    • rendererType
    • disableLeaveAlert
    • disableResizeOverlay
    • disableReconnect
    • enableZmodem
    • enableTrzsz
    • trzszDragInitTimeout
    • enableSixel
    • titleFixed
    • isWindows
    • unicodeVersion

@cangzhang
Copy link
Contributor Author

Updated. plz have a look

@tsl0922 tsl0922 closed this Mar 26, 2024
@tsl0922
Copy link
Owner

tsl0922 commented Mar 26, 2024

Merged manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cangzhang @tsl0922