job: add activeDeadlineSeconds option and fix teams info #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 71.41% 71.45% +0.03%
==========================================
Files 44 44
Lines 8190 8211 +21
==========================================
+ Hits 5849 5867 +18
- Misses 1516 1519 +3
Partials 825 825
☔ View full report in Codecov by Sentry. |
wpjunior
reviewed
Oct 4, 2023
tsuru/client/jobs.go
Outdated
| Description: c.description, | ||
| TeamOwner: c.teamOwner, | ||
| Manual: c.manual, | ||
| ActiveDeadlineSeconds: c.maxRunningTime, |
There was a problem hiding this comment.
@morpheu sending ActiveDeadlineSeconds as 0 is a problem?
There was a problem hiding this comment.
It should be handle on the API also, but on client I think we should send 0 to inform server that should set default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.