Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Missing confirmation input message #224

Merged
merged 2 commits into from
May 2, 2024

Conversation

gvicentin
Copy link
Member

Using the tsuru-client sometimes we can't see the confirmation input before entering the answer.

How to reproduce:

# normal behaviour
$ tsuru app remove -a gvicentin-static
Are you sure you want to remove app "gvicentin-static"? (y/n) n
Abort.

# bug happens not only here but with some other commands too
$ tsuru service instance remove rpaasv2-be gvicentin-be
n
Are you sure you want to remove the instance "gvicentin-be"? (y/n) Abort.

Since every confirmation input should not use pagination, we can call the RawOutput function to fix this weird behaviour.
Dependency PR: tsuru/tsuru#2693

@gvicentin gvicentin marked this pull request as ready for review April 30, 2024 17:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (1e295e0) to head (8cee29c).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   70.89%   71.05%   +0.16%     
==========================================
  Files          55       55              
  Lines        8809     8824      +15     
==========================================
+ Hits         6245     6270      +25     
+ Misses       1675     1663      -12     
- Partials      889      891       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvicentin gvicentin requested a review from wpjunior May 2, 2024 11:57
@wpjunior wpjunior merged commit 59bdc44 into tsuru:master May 2, 2024
6 checks passed
@gvicentin gvicentin deleted the fix/confirm-input branch May 2, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants