Merge pull request #1748 from tursodatabase/lucio/graceful-connisprimary

sqld: gracefully reject schema migration on replica
tursodatabase · Sep 18, 2024 · 32150fe · 32150fe
2 parents 5129424 + 3e192cf
commit 32150fe
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/libsql-server/src/rpc/proxy.rs b/libsql-server/src/rpc/proxy.rs
@@ -633,7 +633,12 @@ impl Proxy for ProxyService {
                     tracing::debug!("connected: {client_id}");
                     match connection_maker.create().await {
                         Ok(conn) => {
-                            assert!(conn.is_primary());
+                            if !conn.is_primary() {
+                                return Err(tonic::Status::failed_precondition(
+                                    "cannot run schema migration against a replica",
+                                ));
+                            }
+
                             let conn = Arc::new(TimeoutConnection::new(conn));
                             let mut lock = RwLockUpgradableReadGuard::upgrade(lock).await;
                             lock.insert(client_id, conn.clone());
@@ -703,7 +708,12 @@ impl Proxy for ProxyService {
                 tracing::debug!("connected: {client_id}");
                 match connection_maker.create().await {
                     Ok(conn) => {
-                        assert!(conn.is_primary());
+                        if !conn.is_primary() {
+                            return Err(tonic::Status::failed_precondition(
+                                "cannot run schema migration against a replica",
+                            ));
+                        }
+
                         let conn = Arc::new(TimeoutConnection::new(conn));
                         let mut lock = RwLockUpgradableReadGuard::upgrade(lock).await;
                         lock.insert(client_id, conn.clone());