Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): update input uncontrolled value #5186

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

chenglu4343
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ❌ Failed (Inspect) Dec 20, 2023 6:41pm

@chenglu4343 chenglu4343 temporarily deployed to test August 29, 2023 01:40 — with GitHub Actions Inactive
@chenglu4343 chenglu4343 temporarily deployed to test August 29, 2023 01:40 — with GitHub Actions Inactive
@chenglu4343 chenglu4343 temporarily deployed to test August 29, 2023 01:40 — with GitHub Actions Inactive
@chenglu4343 chenglu4343 temporarily deployed to test August 29, 2023 01:40 — with GitHub Actions Inactive
@chenglu4343
Copy link
Contributor Author

fix #5184

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01% ⚠️

Comparison is base (2167367) 62.39% compared to head (463be6b) 62.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5186      +/-   ##
==========================================
- Coverage   62.39%   62.38%   -0.01%     
==========================================
  Files        1074     1074              
  Lines       22588    22591       +3     
  Branches     5930     5931       +1     
==========================================
  Hits        14093    14093              
- Misses       6954     6957       +3     
  Partials     1541     1541              
Files Changed Coverage Δ
src/radio/src/use-radio.ts 59.67% <25.00%> (-3.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@07akioni
Copy link
Collaborator

我先合并了,有更好的做法

@07akioni 07akioni merged commit 9c03ff7 into tusen-ai:main Dec 20, 2023
3 of 4 checks passed
@07akioni
Copy link
Collaborator

更好的解法参考 adbeac1

liuzw2579 pushed a commit to liuzw2579/ithinkdt-ui that referenced this pull request Dec 21, 2023
@chenglu4343 chenglu4343 deleted the fix-radio branch February 27, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants