-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Greetings.yml added #34
Conversation
@praptisharma28 you will have to install pre-commit |
Added precomit in the environment variables , still its not recognised ? @tushar5526 |
https://pre-commit.com/ - Setup this |
done @tushar5526 |
requirements.txt
Outdated
filelock==3.13.1 | ||
pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit will rather go in requirements-dev.txt
as it is a dev requirement not a core requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move pre-commit to dev requirements.
ok done @tushar5526 , dev already have a version of pre-commit. removed from requirements.txt . You can check now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 3 3
Lines 276 276
=======================================
Hits 241 241
Misses 35 35 ☔ View full report in Codecov by Sentry. |
@tushar5526 do I need to do anything more? |
closes #33