Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix .order values in the migration guide #41030

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 13, 2024

Description

While answering to #41029, I spotted a tiny error in our migration guide.

We also have .order-0:

.order-first {
order: -1 !important;
}
.order-0 {
order: 0 !important;
}
.order-1 {
order: 1 !important;
}
.order-2 {
order: 2 !important;
}
.order-3 {
order: 3 !important;
}
.order-4 {
order: 4 !important;
}
.order-5 {
order: 5 !important;
}
.order-last {
order: 6 !important;
}

And it was already the case in Bootstrap v5.0.0 (source: https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.css)

Type of changes

  • Docs fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review November 13, 2024 15:28
@julien-deramond julien-deramond merged commit f9b32bc into main Nov 13, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-order-values-in-migration-guide branch November 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants