Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum pattern compilation #1817

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Enum pattern compilation #1817

merged 1 commit into from
Feb 16, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented Feb 14, 2024

Depends on #1816

Follow-up of #1816. Implement missing enum pattern compilation, making matchv2 able to handle full-fledged pattern matching.

Follow-up

  • Special case matching on a bunch of enum tags to restore the previous behavior, which used to index directly in a record containing the body of each branch. Honestly, given the size of the matches, it's not clear that this is a huge gain: for now, I would just add the general "make pattern compilation produce more efficient code" to Performance improvement ideas: tracking issue #1484, and only explore this path if pattern matching is shown to be too slow.

@yannham yannham requested review from jneem and vkleen February 14, 2024 09:02
@github-actions github-actions bot temporarily deployed to pull request February 14, 2024 09:06 Inactive
@yannham yannham force-pushed the feat/enum-pattern-elaboration branch from af68e72 to a262f73 Compare February 14, 2024 10:55
@github-actions github-actions bot temporarily deployed to pull request February 14, 2024 10:59 Inactive
Base automatically changed from feat/pattern-elaboration to master February 15, 2024 19:31
Copy link

dpulls bot commented Feb 15, 2024

🎉 All dependencies have been resolved !

@yannham yannham force-pushed the feat/enum-pattern-elaboration branch from a262f73 to 6fdb212 Compare February 16, 2024 07:46
@yannham yannham enabled auto-merge February 16, 2024 07:48
@github-actions github-actions bot temporarily deployed to pull request February 16, 2024 07:50 Inactive
@yannham yannham added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit 0234427 Feb 16, 2024
5 checks passed
@yannham yannham deleted the feat/enum-pattern-elaboration branch February 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants