Create blockquote #4168
Merged
Create blockquote #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PixeledCode
commented
Nov 21, 2024
•
PixeledCode
commented
- Add Blockquote component
- Add Blockquote Icon
- Update Box component
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fd6a26b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +1.7 kB (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
🦋 Changeset detectedLatest commit: fd6a26b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PixeledCode
force-pushed
the
create-blockquote
branch
from
b6a39e5 to
d145b7b
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd6a26b:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
create-blockquote
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | Nora Krantz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
dosubot
bot
added
the
size:XL
nkrantz
force-pushed
the
create-blockquote
branch
from
97a3257 to
1d3f787
Compare
| expect(blockquote).toBeDefined(); | ||
| const text = screen.getByText("This is some text."); | ||
| expect(text.nodeName).toBe("BLOCKQUOTE"); | ||
| expect(text).toHaveAttribute("cite", "#"); |
| > | ||
| <BlockquoteIcon element={`${element}_ICON`} decorative={true} color="colorTextIcon" /> | ||
| <BlockquoteContext.Provider value={{ url }}> | ||
| <Box element={`INNER_${element}`}>{children}</Box> |
There was a problem hiding this comment.
Did we decide whether this was needed? Does it do weird stuff because the parent is a flex container?
There was a problem hiding this comment.
yeah exactly, it's needed for flex reasons, so I added a customization target and called it a day
krisantrobus
previously approved these changes
Nov 26, 2024
krisantrobus
approved these changes
Nov 27, 2024
nkrantz
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
create-blockquote
|
| Run status |
|
| Run duration | 06m 06s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
jhanvi1399
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.