Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for oauth #1045

Closed
wants to merge 10 commits into from
Closed

chore: add support for oauth #1045

wants to merge 10 commits into from

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

This PR adds support for accessing Twilio APIs using OAuth2 as well. It adds the following classes:

  1. Token Managers to fetch access token
  2. AuthStrategy to use tokens and create authString
  3. Credential Providers to choose different auth strategy, be it - Basic Auth, OAuth or NoAuth (Limited use)
  4. Modifications to Client to accomodate new changes without breaking previous flow

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635
Copy link
Contributor Author

Add tests for validating OAuth based api calls

Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant