fix: Fix externals not being ignored by .chezmoiignore #3197
Conversation
|
Tests failing due to changed patterns, need help in adjusting them, as I don't see through which one exactly has failed |
stablestud
force-pushed
the
fix/externals-ignore-chezmoiignore
branch
from
1c966cb
to
e7aa663
Compare
internal/chezmoi/sourcestate.go
Outdated
| @@ -1403,6 +1403,9 @@ func (s *SourceState) addPatterns( | |||
| include = patternSetExclude | |||
| } | |||
| pattern := dir.JoinString(text).String() | |||
| if !strings.HasSuffix(pattern, "/**") { | |||
| pattern = pattern + "/**" | |||
There was a problem hiding this comment.
If this fix is appropriate (if no better solution exists) we might discuss where to put this pattern extension (/**).
It can be put either here, only being applying on source state reads or directly into patternset.go#Match effecting all dependent "packages".
There was a problem hiding this comment.
I actually prefer to put it into patternset.go#Match as the behavior of doublestar is strange and unexpected for ignoring files (.config/i3 does not match .config/i3/theme.conf)
|
Your force-push didn't change anything, did you forget to commit? The linter wants |
|
This change is not correct. chezmoi explicitly treats the patterns |
stablestud
force-pushed
the
fix/externals-ignore-chezmoiignore
branch
from
e7aa663
to
ae55c1e
Compare
|
I saw the issue. It is not a bug. This change will break everybody who relies on chezmoi's existing behavior. |
|
Then this can be closed |
fixes #3196