Area API + getDoc without markdown contents #75
Conversation
…nts from all GET to appropriate type following RESTful practices)
for the s3 endpoints to begin area api work
…ification of db setup script
There was a problem hiding this comment.
Hi @KeveenWong,
good work! it needs some fixing before merging in main.
It has been deployed though so it e.g. getAreas - however it's not ready imo
i've left comments but in general:
- updating sql tables to follow naming conventions (and consequently the db.ts type definitions)
- input restrictions on area and doc name (refer to the comment)
- area api should be fully functional (CRUD Area, CRUD Doc (in db terms not s3))
- number of doc removal/change
Note on SQL scripts:
To make changes to sql tables don't redo the whole script again. Use Alter. Create new files that alter the tables to your liking since deployed can't undo.
When you run db:up it will only run sql scripts with timestamps after its last execution
so make sure your .sql files are in Unix seconds. i noticed you had appended a wiki suffix to it.
(for local dev remember to rename db name to whatever you use)
Once done with these make sure you run
npm run lint to see if there are linting issues
and npm run format to format the code
and as always test locally
|
@KeveenWong how are we doing on this? |
Completed area API and getDoc to get metadata of contents.