-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented object store loading from parsed JSONs #806
Open
namanhd
wants to merge
24
commits into
dev
Choose a base branch
from
wdl/parsing-wdz-namanh
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed obj to object in places - changed TYPE_NONE and TYPE_ERROR - dummy j_obj to game_obj conversion
…cs/chiventure into wdl/parsing-wdz-namanh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #800, we have now implemented the loading functionality that turns the parsed JSON objects into our own object representation, and load those objects into our own object store so that objects can be accessed by other modules.
More work is needed to actually integrate this object store with other modules so that they can load their own structures, but this is a solid foundation for that step later on. The entry point and outputs for this code is the same as #800; it can be seen by running chiventure with a wdz file, then closing the the UI. The output from the reading is printed to stdout.