Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/multi value #375

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Bug/multi value #375

merged 8 commits into from
Jul 25, 2024

Conversation

scherztc
Copy link
Contributor

Pulled Javascript out of views and into asset pipeline.
Adjusted HTML to get the count and ID right to properly delete
Product_Owners
Tech_Leads
Departments
Admin_users

@scherztc scherztc force-pushed the bug/multi_value branch 2 times, most recently from df09e31 to 83f3d6d Compare July 15, 2024 18:56
@scherztc scherztc changed the title WIP : Bug/multi value Bug/multi value Jul 15, 2024
@scherztc scherztc force-pushed the bug/multi_value branch 5 times, most recently from 3b3457e to 20f7d3f Compare July 15, 2024 20:50
@Janell-Huyck Janell-Huyck self-assigned this Jul 16, 2024
app/assets/javascripts/custom.js Outdated Show resolved Hide resolved
app/views/layouts/application.html.erb Show resolved Hide resolved
app/views/layouts/software_records.html.erb Show resolved Hide resolved
config/initializers/assets.rb Show resolved Hide resolved
@Janell-Huyck
Copy link
Contributor

The changed code works appropriately when run locally. I'm able to correctly add and remove members, and the item I click to delete is the one that's actually removed.

Copy link
Contributor

@Janell-Huyck Janell-Huyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking up the giant files. Let's get this rolling!

@Janell-Huyck Janell-Huyck merged commit 64bc907 into qa Jul 25, 2024
4 checks passed
@Janell-Huyck Janell-Huyck deleted the bug/multi_value branch July 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants