Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused dependencies #295

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Removed unused dependencies #295

merged 5 commits into from
Sep 28, 2024

Conversation

Drayiss
Copy link
Contributor

@Drayiss Drayiss commented Sep 26, 2024

Removed the following:

Unused dependencies

  • @expo/vector-icons
  • expo-constants
  • expo-linking
  • expo-splash-screen
  • expo-status-bar
  • expo-web-browser
  • firebase (but kept @firebase/firestore)
  • react-dom
  • react-native-reanimated
  • react-native-web

Unused devDependencies

Copy link
Collaborator

@fmcubium fmcubium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the backend for unused dependencies as well. If there are no unused dependencies in the backend, just reply to this comment saying that.

@Drayiss
Copy link
Contributor Author

Drayiss commented Sep 28, 2024

Ok, I checked the backend for unused dependencies as well. I found some and removed some in my latest commit.

Results of the backend packages:

Successfully removed:

  • cors
  • ts-node

Unsuccessfully removed:

@h1divp
Copy link
Collaborator

h1divp commented Sep 28, 2024

Jest is used as a development dependency for our test scripts ran by npm test, I wouldn't move its types package into the main dependency list.
Cors should also be used later for the web (express.js) API, not sure why it isn't included anywhere but doing so will probably avoid some future headaches for why the server may not be able to receive data (see this link).
ts-node also sounds important to me, but I tested running the server without it and it seems to run fine... I'm okay with it being removed but if it causes some large issue, the fix can be made quickly at least, by reinstalling.

I would keep those two packages the way they were.

I'm not too educated on the front-end packages, so I'll save my judgement there. Thank you for your help.

@Drayiss
Copy link
Contributor Author

Drayiss commented Sep 28, 2024

Ok, I reverted my previous commit and kept things the way they were, except I removed ts-node.

@Drayiss Drayiss closed this Sep 28, 2024
@Drayiss Drayiss reopened this Sep 28, 2024
@fmcubium fmcubium merged commit 411e57d into ufosc:main Sep 28, 2024
3 checks passed
@fmcubium
Copy link
Collaborator

lgtm

@Drayiss Drayiss deleted the feature branch September 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused dependencies clogging up our ecosystem
4 participants