allow diagnostic accumulation bucket to change in fv3atm integration

[junwang-noaa]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

The code updates are to allow diagnostic accumulation bucket to change during integration in FV3ATM.

The PR is tested.

Commit Message

Develop new capability to allow diagnostic accumulation bucket to change in fv3atm integration

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
• Normal

Blocking Dependencies

NOAA-EMC/fv3atm#775

Git Issues Fixed By This PR

Closes #1983

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

FAILED REGRESSION TESTS

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[junwang-noaa]

@MatthewPyle-NOAA The code changes are completed. I tested the regional_control test, the results look good to me. Currently the code allows two different buckets during integration, to turn on the feature, please add two variables in the input.nml:

&gfs_physics_nml
fhzero = 1.
fhzero_array = 1., 3.
fhzero_fhour = 3., 6.

fhzero_array contains the bukcets, the fhzero_shour has the forecast hours using the buckets. E.g. in above case, forecast 0-3 hour will have 1 hour bucket, then the model has 3 hour bucket up to forecast hour 6. The fhzero is not used in this case. Please let me know if this is what RRFS needs. Thanks

[MatthewPyle-NOAA]

@junwang-noaa sorry for the slow response. Can fhzero_array take fractional values (like 0.25 if we wanted 15 minute buckets)?

[junwang-noaa]

Sorry, there is a merging issue, I recreated my ufs weather model branch. @MatthewPyle-NOAA The fhzero_array is real number, 0.25 hour should work, please let me know if it does not.