Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Picker: only allow navigating to folders/media with children + other fixes #17617

Merged
merged 52 commits into from
Nov 25, 2024
Merged

Media Picker: only allow navigating to folders/media with children + other fixes #17617

merged 52 commits into from
Nov 25, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 22, 2024 •
edited
Loading

Important

Merges after: #17623

This is an overhaul of the media picker to fix some general issues:

Fixes

  • Prevent the user from navigating into a media item that is not a folder or that doesn't have children
  • When an item is selected we enter a "selection mode" where it is faster to select items
  • Improved UX when searching inside a media item
  • Use the UmbMediaSearchProvider for searching instead of the media item repository
  • Prevent searching outside the configured start node
  • Handle start node in the breadcrumb

What to test

  • Select items
  • Navigate into folders
  • Navigate into items with children
  • Search from root
  • Search within an item/folder
  • Navigate with breadcrumb

madsrasmussen and others added 30 commits November 22, 2024 08:19
@madsrasmussen
only allow navigating into folders or item with children
0e3a9dc
@madsrasmussen
export media search provider
6133a27
@madsrasmussen
mark search on media item repo as deprecated
95a5840
@madsrasmussen
use media search provider for searching
6fb0848
@madsrasmussen
rename method
545ba76
@madsrasmussen
change the look of the upload button
987623c
@madsrasmussen
only render checkbox if we are not in the root
0b0ad39
@madsrasmussen
clear search when navigating
d04da2d
@madsrasmussen
add type
496b220
@madsrasmussen
set value so it gets updated when cleared
608eb95
@madsrasmussen
default to search within an item
b1dfe0c
@madsrasmussen
hide breadcrumb if searching in root
f983dfe
@madsrasmussen
scope search on server
4e66029
@madsrasmussen
Update media-picker-modal.element.ts
08b45fe
@madsrasmussen
hide breadcrumb when doing a global search within another item
d6725dc
@madsrasmussen
add selection mode
eadf494
@madsrasmussen
Merge branch 'v15/dev' into v15/bugfix/prevent-navigating-to-non-fold…
2e2f180 
…ers-in-media-picker
@madsrasmussen
remove unused state
6a2e556
@madsrasmussen
handle start node when searching
a899ef4
@madsrasmussen
fix if wrong order
2a05b1a
@madsrasmussen
fix type error
ff66714
@madsrasmussen
pass start node to breadcrumb
5258c61
@madsrasmussen
handle start node in breadcrumb
5bbfd3b
@madsrasmussen
make start node optional
6b4e82c
@madsrasmussen
map data
a99f2fa
@madsrasmussen
clean up
5527f58
@madsrasmussen
Update media-picker-folder-path.element.ts
6ec9023
@madsrasmussen
add searching load indicator
d37e0f0
@madsrasmussen
don't show unique in detail
0153a1f
@nikolajlauridsen
Add information to item response model
79f9091
@nielslyngsoe nielslyngsoe self-requested a review November 25, 2024 11:48
@nielslyngsoe nielslyngsoe self-assigned this Nov 25, 2024
@madsrasmussen madsrasmussen changed the title V15: bugfix: Prevent navigating to non folders/media without children in media picker V15: bugfix: Media Picker: only allow navigating to folders/media with children + other Nov 25, 2024
@madsrasmussen madsrasmussen changed the title V15: bugfix: Media Picker: only allow navigating to folders/media with children + other Bugfix: Media Picker: only allow navigating to folders/media with children + other Nov 25, 2024
@madsrasmussen madsrasmussen changed the title Bugfix: Media Picker: only allow navigating to folders/media with children + other Media Picker: only allow navigating to folders/media with children + other Nov 25, 2024
@madsrasmussen madsrasmussen changed the title Media Picker: only allow navigating to folders/media with children + other Media Picker: only allow navigating to folders/media with children + other fixes Nov 25, 2024
nielslyngsoe
nielslyngsoe reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good off to test

madsrasmussen and others added 12 commits November 25, 2024 13:18
@nielslyngsoe nielslyngsoe merged commit 16a5f8d into v15/dev Nov 25, 2024
19 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/bugfix/prevent-navigating-to-non-folders-in-media-picker branch November 25, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees

@nielslyngsoe nielslyngsoe

Labels
area/frontend release/15.1.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @nielslyngsoe @nikolajlauridsen