unpin mypy from requirements, only run mypy CI on py3.10+

Signed-off-by: Niels Bantilan <[email protected]>
unionai-oss · Sep 14, 2023 · 7abaad7 · 7abaad7
1 parent 850dcf8
commit 7abaad7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
@@ -200,8 +200,9 @@ jobs:
       - name: Unit Tests - IO
         run: pytest tests/io ${{ env.PYTEST_FLAGS }}
 
+      # only test mypy plugin for python 3.10+ and latest version of pandas
       - name: Unit Tests - Mypy
-        if: ${{ matrix.python-version != '3.7' }}
+        if: ${{ !contains(fromJson('["3.7", "3.8", "3.9"]'), matrix.python-version) && matrix.pandas-version == '2.0.3' }}
         run: pytest -v tests/mypy ${{ env.PYTEST_FLAGS }}
 
       - name: Unit Tests - Strategies

diff --git a/environment.yml b/environment.yml
@@ -22,7 +22,7 @@ dependencies:
   - multimethod
 
   # mypy extra
-  - pandas-stubs <= 1.5.2.221213
+  - pandas-stubs
 
   # pyspark extra
   - pyspark >= 3.2.0
@@ -47,7 +47,7 @@ dependencies:
 
   # testing
   - isort >= 5.7.0
-  - mypy <= 0.982
+  - mypy
   - pylint <= 2.17.3
   - pytest
   - pytest-cov

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -15,7 +15,7 @@ frictionless <= 4.40.8
 pyarrow
 pydantic
 multimethod
-pandas-stubs <= 1.5.2.221213
+pandas-stubs
 pyspark >= 3.2.0
 modin
 protobuf
@@ -26,7 +26,7 @@ shapely
 fastapi
 black >= 22.1.0
 isort >= 5.7.0
-mypy <= 0.982
+mypy
 pylint <= 2.17.3
 pytest
 pytest-cov

diff --git a/tests/mypy/test_static_type_checking.py b/tests/mypy/test_static_type_checking.py
@@ -114,7 +114,7 @@ def test_pandera_runtime_errors(fn) -> None:
 ]
 
 PYTHON_SLICE_ERRORS = [
-    {"msg": "Slice index must be an integer or None", "errcode": "misc"},
+    {"msg": "Slice index must be an integer", "errcode": "misc"},
 ]
 
 PANDAS_INDEX_ERRORS = [