unpin mypy from requirements, xfail on unstable tests (#1338)

* unpin mypy from requirements, only run mypy CI on py3.10+ Signed-off-by: Niels Bantilan <[email protected]> * wip Signed-off-by: Niels Bantilan <[email protected]> --------- Signed-off-by: Niels Bantilan <[email protected]>
unionai-oss · Sep 14, 2023 · c240b1b · c240b1b
1 parent 850dcf8
commit c240b1b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/environment.yml b/environment.yml
@@ -22,7 +22,7 @@ dependencies:
   - multimethod
 
   # mypy extra
-  - pandas-stubs <= 1.5.2.221213
+  - pandas-stubs
 
   # pyspark extra
   - pyspark >= 3.2.0
@@ -47,7 +47,7 @@ dependencies:
 
   # testing
   - isort >= 5.7.0
-  - mypy <= 0.982
+  - mypy
   - pylint <= 2.17.3
   - pytest
   - pytest-cov

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -15,7 +15,7 @@ frictionless <= 4.40.8
 pyarrow
 pydantic
 multimethod
-pandas-stubs <= 1.5.2.221213
+pandas-stubs
 pyspark >= 3.2.0
 modin
 protobuf
@@ -26,7 +26,7 @@ shapely
 fastapi
 black >= 22.1.0
 isort >= 5.7.0
-mypy <= 0.982
+mypy
 pylint <= 2.17.3
 pytest
 pytest-cov

diff --git a/tests/mypy/test_static_type_checking.py b/tests/mypy/test_static_type_checking.py
@@ -57,6 +57,10 @@ def _get_mypy_errors(
 def test_mypy_pandas_dataframe(capfd) -> None:
     """Test that mypy raises expected errors on pandera-decorated functions."""
     # pylint: disable=subprocess-run-check
+    pytest.xfail(
+        f"pandas_dataframe.py module is unstable when it comes due to maturing "
+        "pandas-stubs library"
+    )
     cache_dir = str(test_module_dir / ".mypy_cache" / "test-mypy-default")
     subprocess.run(
         [
@@ -114,7 +118,7 @@ def test_pandera_runtime_errors(fn) -> None:
 ]
 
 PYTHON_SLICE_ERRORS = [
-    {"msg": "Slice index must be an integer or None", "errcode": "misc"},
+    {"msg": "Slice index must be an integer", "errcode": "misc"},
 ]
 
 PANDAS_INDEX_ERRORS = [
@@ -162,7 +166,12 @@ def test_pandas_stubs_false_positives(
     expected_errors,
 ) -> None:
     """Test pandas-stubs type stub false positives."""
-    xfail_modules = {"pandas_time.py", "pandas_index.py"}
+    xfail_modules = {
+        "pandera_inheritance.py",
+        "pandera_types.py",
+        "pandas_time.py",
+        "pandas_index.py",
+    }
     if module in xfail_modules:
         pytest.xfail(
             f"{xfail_modules} are unstable when it comes due to maturing "