Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PySpark] Improve validation performance by enabling
cache()
/unpersist()
toggles #1414[PySpark] Improve validation performance by enabling
cache()
/unpersist()
toggles #1414Changes from 3 commits
74f6c33
dc652e8
3f67576
ee0e42c
952bef3
08f0a25
ddb4570
eec060b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 14 in pandera/backends/pyspark/container.py
Codecov / codecov/patch
pandera/backends/pyspark/container.py#L14
Check warning on line 109 in pandera/backends/pyspark/container.py
Codecov / codecov/patch
pandera/backends/pyspark/container.py#L109
Check warning on line 4 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L4
Check warning on line 6 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L6
Check warning on line 12 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L12
Check warning on line 17 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L17
Check warning on line 136 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticing, this isn't true for the other dectorators in this file either but would it make sense to cleariy in the docstring that this is a decorator factory and should decorated with
cache_check_obj
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something similar to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the new explanation (I'll make use of it hehe) but I'm not sure if explaining this common design pattern is valuable here. We would need to add this explanation to others decorators too, to keep the standard and we would end bloating the docstrings with repeated information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!
Check warning on line 151 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L149-L151
Check warning on line 155 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L154-L155
Check warning on line 161 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L158-L161
Check warning on line 167 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L166-L167
Check warning on line 170 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L169-L170
Check warning on line 172 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L172
Check warning on line 174 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L174
Check warning on line 177 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L176-L177
Check warning on line 180 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L179-L180
Check warning on line 182 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L182
Check warning on line 184 in pandera/backends/pyspark/decorators.py
Codecov / codecov/patch
pandera/backends/pyspark/decorators.py#L184
Check warning on line 30 in pandera/config.py
Codecov / codecov/patch
pandera/config.py#L29-L30