Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix | Geopandas import error #1476

Conversation

biswa-mohapatra
Copy link

The pandera import was not working as the geopandas.py was not being imported properly to the the pandera backend pandas init.py file. Finxed this issue.

Signed-off-by: biswa-mohapatra <[email protected]>
Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biswa-mohapatra can you:

  1. share a code snippet that reproduces the bug you're encountering
  2. the stack trace of the error

@@ -2,7 +2,8 @@

import pandas as pd

import pandera.typing
# import pandera.typing
from pandera.typing import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit imports are preferred over * imports, as it better controls what symbols are imported into the namespace.

@cosmicBboy
Copy link
Collaborator

the approach taken in this PR is an antipattern (using import *), feel free to re-open this PR when the problem statement and solution are clearer.

@cosmicBboy cosmicBboy closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants