Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voyager v2 #2661

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Voyager v2 #2661

merged 1 commit into from
Sep 17, 2024

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Aug 5, 2024 •
edited
Loading

Plugins and Modules

Changes

  • unique errors for connection and client state verification in ibc-solidity connection handshake verification
  • more attributes on generated prost types for cometbft-rpc
  • more canonical types in unionlabs for generated prost types
  • the great untyping:
    • beacon-api-client is now fully generic over chain spec and does not take a generic for chain spec
    • unionlabs::ics24::Path is no longer generic, using only concrete types
    • unionlabs::ics24::IbcPath is no longer generic, using only concrete types
      • IbcPath::Value for client and consensus state paths are now just opaque bytes
    • unionlabs::event::IbcEvent is no longer generic, using only concrete types
    • all of the IBC Msg* are no longer generic, using only concrete types
    • added Unbounded* versions of all of the types in unionlabs::ethereum::beacon that are generic over ChainSpec, for use in beacon-api-client
      • open to better naming here
    • unionlabs::QueryHeight is no longer generic, using only the concrete type Height
  • removed a bunch of old commented out code
  • queue_msg:
    • removed OpEvent/QueueMessage::Event (no longer useful with the new architecture)
  • added new RawAny type, since some cosmos types use a dynamic list of Any values and as such they must be type-erased
  • cleaned up unionlabs::ethereum::beacon to follow the structure of the rest of the crate (one module/file per type)
  • #[model] now derives Eq

Closes

Non-code refactors

  • normalize comments in rust code (mostly affected generated code)

chain-utils is a bit of a mess right now, this crate will be drastically refactored in the coming weeks. i recommend just kinda not looking at it too hard

@benluelo benluelo force-pushed the voyager-v2 branch 3 times, most recently from 20e1e01 to 7937c4f Compare August 10, 2024 00:04
@cor cor added P-high High priority A-voyager Area: Our voyager relayer E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. and removed E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks. labels Aug 12, 2024
@benluelo benluelo force-pushed the voyager-v2 branch 3 times, most recently from 45da996 to c49feac Compare August 15, 2024 13:53
@benluelo benluelo force-pushed the voyager-v2 branch 6 times, most recently from 910b03e to 068657a Compare September 6, 2024 12:38
@benluelo benluelo force-pushed the voyager-v2 branch 3 times, most recently from 0c222c3 to a1fc398 Compare September 12, 2024 13:09
@unionlabs unionlabs deleted a comment from netlify bot Sep 16, 2024
@benluelo benluelo marked this pull request as ready for review September 16, 2024 18:01
@benluelo benluelo force-pushed the voyager-v2 branch 2 times, most recently from bb52029 to 6f6eba8 Compare September 16, 2024 18:51
@benluelo
feat(voyager)!: voyager v2
61b5224 
wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

wip

normalize comments

wip

wip: cleanup

wip

wip

wip

wip: newtype chain id

wip: cleanup

wip

wip: cleanup

wip: cleanup

wip

wip

cleanup after rebase

wip

wip

wip: update movement protos & fmt

wip

wip

wip: typetagged magic

take that, move

wip: fmt

wip: more betterer codegen

wip

wip

wip

wip

feat: package modules and allow plugin conf

wip

fix: modules and plugins

wip: dev

wip: voyager-modules

wip: fix enabled option

wip: log format

wip: fix

wip

wip

wip: ws or http idc

wip

wip: yeet

wip: time to test in prod

wip: slight cleanup

wip: fix voyager.nix

wip: less exploding in cosmos-sdk chian module

wip: extract reconnecting client to library

wip: pain

wip: ? is dangerous

wip: oops

wip

wip: oops again

wip: moar logs

wip: check if packet already sent

wip: don't drop updates if queue is empty

wip: clean up clean up

everybody everywhere

wip

wip: no more splodey

wip: add wait until connectec to cometbft-rpc

wip: cleanup

wip: don't cancel on drop

ask me how long i spent figuring this out

wip: fix panic

wip

wip
@github-actions GitHub Actions
Copy link

Docs 🤌

✨ Deployment complete! Take a peek over at https://9590cea9.docs-ajn.pages.dev
✨ Deployment alias URL: https://head.docs-ajn.pages.dev

aeryz
aeryz approved these changes Sep 16, 2024
View reviewed changes
lib/cometbft-rpc/src/lib.rs Show resolved Hide resolved
lib/cometbft-rpc/src/types.rs Show resolved Hide resolved
lib/queue-msg/src/lib.rs Show resolved Hide resolved
lib/voyager-message/src/call.rs Show resolved Hide resolved
move/mock_ibc_module.move Show resolved Hide resolved
move/move-ibc/.movement/config.yaml Show resolved Hide resolved
@benluelo benluelo merged commit 0ddbf5a into main Sep 17, 2024
209 checks passed
@benluelo benluelo deleted the voyager-v2 branch September 17, 2024 13:50
@benluelo benluelo mentioned this pull request Sep 17, 2024
Merged
benluelo added a commit that referenced this pull request Sep 17, 2024
@benluelo
chore: cleanup (#2971)
67845d4 
cleanup after #2661
This was referenced Sep 21, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeryz aeryz aeryz approved these changes

@PoisonPhang PoisonPhang PoisonPhang approved these changes

@cor cor cor approved these changes

Assignees
No one assigned
Labels
A-voyager Area: Our voyager relayer E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. P-high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benluelo @cor @PoisonPhang @aeryz