Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move app to sdk #2902

Merged
merged 12 commits into from
Sep 9, 2024
Merged

feat: move app to sdk #2902

merged 12 commits into from
Sep 9, 2024

Conversation

o-az
Copy link
Member

@o-az o-az commented Sep 2, 2024

No description provided.

@o-az o-az requested review from cor and PoisonPhang as code owners September 2, 2024 22:08
@unionlabs unionlabs deleted a comment from netlify bot Sep 2, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 2, 2024 •
edited
Loading 

npm i https://pkg.pr.new/unionlabs/union/@union/client@2902

commit: 9aec302

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

App 🤌

🌎 Deploying...
✨ Deployment complete! Take a peek over at https://e79f8d05.app-1b1.pages.dev

cor
cor requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great sir!

One general comment is that i'd love to have nice integration of neverthrow with xstate, rather than doing if err throw. but that can be part of a future PR

Other than that just some small questions

app/src/lib/components/chains-gate.svelte Show resolved Hide resolved
app/src/lib/wallet/cosmos/config.ts Outdated Show resolved Hide resolved
app/src/routes/transfer/(components)/transfer-form.svelte Show resolved Hide resolved
app/src/routes/transfer/(components)/transfer-form.svelte Outdated Show resolved Hide resolved
app/src/routes/transfer/(components)/transfer-form.svelte Show resolved Hide resolved
app/src/routes/transfer/(components)/transfer-form.svelte Show resolved Hide resolved
@o-az o-az requested a review from cor September 9, 2024 15:54
@o-az o-az merged commit 81311fe into main Sep 9, 2024
210 checks passed
@o-az o-az deleted the move-app-to-sdk branch September 9, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoisonPhang PoisonPhang PoisonPhang left review comments

@cor cor cor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o-az @cor @PoisonPhang