Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cosmwasm): introduce union-ibc #3212

Merged
merged 24 commits into from
Nov 7, 2024
Merged

feat(cosmwasm): introduce union-ibc #3212

merged 24 commits into from
Nov 7, 2024

Conversation

hussein-aitlahcen
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 11:39pm

hussein-aitlahcen and others added 14 commits November 7, 2024 18:41
@hussein-aitlahcen
feat(cosmwasm): introduce union-ibc
0b6a83e
@aeryz @hussein-aitlahcen
feat(union-ibc): add (intent)recv/send/writeack
8e273c9 
Signed-off-by: aeryz <[email protected]>
@aeryz @hussein-aitlahcen
chore(union-ibc): split execute fn into functions
22e3eef 
Signed-off-by: aeryz <[email protected]>
@aeryz @hussein-aitlahcen
chore(union-ibc): ack
9be8d73 
Signed-off-by: aeryz <[email protected]>
@hussein-aitlahcen
feat(union-ibc): queries from host to light client impls
3fa4da9
@hussein-aitlahcen
feat(union-ibc): acknowledge_packet and timeout_packet implementa…
4af7c11 
…tion + refactor
@aeryz @hussein-aitlahcen
chore(eth-lc): verify (non)membership with union-ibc
e80188b 
Signed-off-by: aeryz <[email protected]>
@hussein-aitlahcen
feat(union-ibc): implements batch_send and batch_acks
2bcc450
@hussein-aitlahcen
chore(union-ibc): cleanup and fmt
a726e74
@aeryz @hussein-aitlahcen
chore(eth-lc): impl getters
6acaae1 
Signed-off-by: aeryz <[email protected]>
@hussein-aitlahcen
fix(union-ibc): use Binary instead of Vec for storage
ddc6fa3
@hussein-aitlahcen
feat(ibc-solidity): duplicate defs to specialize contract address
c8b567d
@hussein-aitlahcen
chore(union-ibc): reuse specialized ibc-solidity defs
0ead724
@hussein-aitlahcen
chore: clippy
a7a9e8d
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Docs 🤌

✨ Deployment complete! Take a peek over at https://0321a4dc.docs-ajn.pages.dev
✨ Deployment alias URL: https://head.docs-ajn.pages.dev

@hussein-aitlahcen hussein-aitlahcen marked this pull request as ready for review November 7, 2024 17:53
benluelo
benluelo reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

general comments:

  • string event keys should be pulled out into constants
  • backlinks to the spec once that's finished

cosmwasm/union-ibc/src/contract.rs Outdated Show resolved Hide resolved
cosmwasm/union-ibc/src/contract.rs Show resolved Hide resolved
cosmwasm/union-ibc/src/contract.rs Show resolved Hide resolved
cosmwasm/union-ibc/src/contract.rs Outdated Show resolved Hide resolved
lib/ibc-solidity/src/cosmwasm/types.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/ics24.rs Outdated Show resolved Hide resolved
benluelo
benluelo reviewed Nov 7, 2024
View reviewed changes
lib/unionlabs/src/ics24.rs Outdated Show resolved Hide resolved
benluelo
benluelo previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

benluelo
benluelo previously approved these changes Nov 7, 2024
View reviewed changes
@benluelo benluelo merged commit c1c1dc4 into main Nov 7, 2024
112 checks passed
@benluelo benluelo deleted the union-ibc branch November 7, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluelo benluelo benluelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussein-aitlahcen @benluelo @aeryz