Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reorganize libraries #3347

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: reorganize libraries #3347

merged 1 commit into from
Dec 6, 2024

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Dec 5, 2024

  • rename IbcVersionId to IbcSpecId as this type no longer represents an IBC version, but rather the entire specification
  • clean up ibc-solidity, removing unused definitions and moving some that are only used in one place into said place where they're used. this crate now only defines the IBC stack itself, so the ibc module was also inlined
  • split IBC spec definitions out of voyager-message into their own crates
    • these crates define the interface of the individual IBC interfaces; there are still some rough edges but this is a good start
  • remove ics24 module from unionlabs and move those store path definitions into the relevant IBC spec libraries
    • TODO: move unionlabs::id as well
  • union-ibc now depends on voyager-core. i'm not super happy about this, but it's fine for now - i'm still working on the library design for the IBC specs, but i will likely split them further such that union-ibc can only depend on the parts it needs.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Dec 5, 2024 10:51pm

@benluelo benluelo merged commit 4ffee44 into main Dec 6, 2024
111 checks passed
@benluelo benluelo deleted the voyager-cleanup branch December 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants