Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use h256 from own crate in evm storage verifier #3377

Conversation

atahanyild
Copy link
Contributor

Fixes #3363

Since Unionlabs::Hash::H256 is already implemented, this refactors the codes that uses primitive_types::H256 to our own one.

Additionally ,this PR implements AsMut to hash.rs as Hasher need AsMut trait to be resolved.

Copy link

vercel bot commented Dec 13, 2024

@atahanyild is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

@atahanyild atahanyild force-pushed the use-H256-from-own-crate-in-evm-storage-verifier branch from a6d3d5b to fab2fe2 Compare December 13, 2024 23:11
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr! lgtm 🚀

@atahanyild atahanyild force-pushed the use-H256-from-own-crate-in-evm-storage-verifier branch from fab2fe2 to dae2a55 Compare December 13, 2024 23:50
@atahanyild atahanyild force-pushed the use-H256-from-own-crate-in-evm-storage-verifier branch from dae2a55 to 6d3940c Compare December 14, 2024 01:37
@benluelo benluelo merged commit 9ab0ebc into unionlabs:main Dec 14, 2024
122 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use unionlabs::hash::H256 in evm-storage-verifier
2 participants