Add FileLoader tests

src/Io/FileLoader.php

@@ -9,9 +9,14 @@
 use Generator;
 use Usox\TalI18nExtract\ExtractorDecorator;
 
+/**
+ * Gets file-paths and returns fully-loaded XPath-objects one-by-one
+ */
 final class FileLoader implements FileLoaderInterface
 {
     /**
+     * Loads every given-file path and return a XPath object
+     *
      * @param iterable<string> $filePaths
      *
      * @return Generator<DOMXPath>
@@ -20,15 +25,13 @@ public function read(
         iterable $filePaths
     ): Generator {
         foreach ($filePaths as $path) {
-            $path = (string) realpath($path);
-
             if (!file_exists($path)) {
                 trigger_error('Not existing: '.$path, E_USER_WARNING);
 
                 continue;
             }
 
-            $content = file_get_contents($path);
+            $content = @file_get_contents($path);
             if ($content === false) {
                 trigger_error('Not readable: '.$path, E_USER_WARNING);
 
@@ -43,10 +46,7 @@ public function read(
                 continue;
             }
 
-            $xpath = new DOMXPath($dom);
-            $xpath->registerNamespace('i18n', ExtractorDecorator::I18N_NAMESPACE);
-
-            yield $xpath;
+            yield new DOMXPath($dom);
         }
     }
 }

src/Io/FileLoaderInterface.php

@@ -8,6 +8,8 @@
 interface FileLoaderInterface
 {
     /**
+     * Loads every given-file path and return a XPath object
+     *
      * @param iterable<string> $filePaths
      *
      * @return Generator<DOMXPath>

tests/Io/FileLoaderTest.php

@@ -0,0 +1,104 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Usox\TalI18nExtract\Io;
+
+use DOMXPath;
+use Exception;
+use org\bovigo\vfs\vfsStream;
+use org\bovigo\vfs\vfsStreamDirectory;
+use org\bovigo\vfs\vfsStreamFile;
+use PHPUnit\Framework\TestCase;
+
+class FileLoaderTest extends TestCase
+{
+    private vfsStreamDirectory $vfsStream;
+
+    private FileLoader $subject;
+
+    protected function setUp(): void
+    {
+        $this->subject = new FileLoader();
+
+        $this->vfsStream = vfsStream::setup('/');
+
+        set_error_handler(static function (int $errno, string $errstr): never {
+            throw new Exception($errstr, $errno);
+        }, E_USER_WARNING);
+    }
+
+    public function testReadFailsIfFileDoesNotExist(): void
+    {
+        $filename = $this->vfsStream->url() . '/snafu';
+
+        static::expectException(Exception::class);
+        static::expectExceptionMessage('Not existing: '.$filename);
+
+        static::assertSame(
+            [],
+            iterator_to_array($this->subject->read([$filename]))
+        );
+    }
+
+    public function testReadFailsIfFileIsNotReadable(): void
+    {
+        $file = new vfsStreamFile('snafu', 0000);
+
+        $this->vfsStream->addChild($file);
+
+        $filename = $file->url();
+
+        static::expectException(Exception::class);
+        static::expectExceptionMessage('Not readable: '.$filename);
+
+        static::assertSame(
+            [],
+            iterator_to_array($this->subject->read([$filename]))
+        );
+    }
+
+    public function testReadFailsIfFileDoesNotContainValidXml(): void
+    {
+        $file = new vfsStreamFile('snafu');
+
+        $this->vfsStream->addChild($file);
+
+        $filename = $file->url();
+
+        file_put_contents($filename, 'snafu');
+
+        static::expectException(Exception::class);
+        static::expectExceptionMessage('Does not contain valid xml: '.$filename);
+
+        static::assertSame(
+            [],
+            iterator_to_array($this->subject->read([$filename]))
+        );
+    }
+
+    public function testReadReturnsPreparedXPathObject(): void
+    {
+        $file = new vfsStreamFile('snafu');
+
+        $this->vfsStream->addChild($file);
+
+        $filename = $file->url();
+
+        file_put_contents($filename, '<?xml version="1.0" encoding="utf-8"?><root>foobar</root>');
+
+        $xpath = current(
+            iterator_to_array($this->subject->read([$filename]))
+        );
+
+        static::assertInstanceOf(
+            DOMXPath::class,
+            $xpath
+        );
+    }
+
+    protected function tearDown(): void
+    {
+        restore_error_handler();
+    }
+}