Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.8+ #289

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Require Python 3.8+ #289

merged 1 commit into from
Sep 11, 2023

Conversation

akx
Copy link
Member

@akx akx commented Sep 11, 2023

Drops the typing-extensions requirement too.

Drops typing-extensions requirement too.
@akx akx marked this pull request as draft September 11, 2023 11:34
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #289 (13e1230) into master (6742467) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   86.68%   86.67%   -0.01%     
==========================================
  Files         125      125              
  Lines        4257     4256       -1     
  Branches      651      879     +228     
==========================================
- Hits         3690     3689       -1     
  Misses        388      388              
  Partials      179      179              
Files Changed Coverage Δ
valohai_cli/ctx.py 80.00% <100.00%> (-0.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx marked this pull request as ready for review September 11, 2023 11:35
@akx akx requested review from a team, teroyks, axelauvinen and tokkoro and removed request for a team September 11, 2023 11:35
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akx akx merged commit 202ad12 into master Sep 11, 2023
8 checks passed
@akx akx deleted the py38 branch September 11, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants