Give API connection errors a specific exception class #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested review from
a team,
hylje and
tokkoro
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 86.74% 86.72% -0.02%
==========================================
Files 126 126
Lines 4359 4362 +3
Branches 907 907
==========================================
+ Hits 3781 3783 +2
- Misses 395 396 +1
Partials 183 183 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make catching these easier in downstream projects like Jupyhai.