Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency upgrades & minor CI renovation #318

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Dependency upgrades & minor CI renovation #318

merged 4 commits into from
Nov 4, 2024

Conversation

akx
Copy link
Member

@akx akx commented Nov 4, 2024 •
edited
Loading

  • Ensure that users get new versions of transitive deps
  • Upgrade lint tools & fix things so they don't complain
  • Speed up CI by using uv
  • Fix Codecov reporting (token was missing; that had worked before, not so anymore)

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (59dc814) to head (ea20c13).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   86.85%   86.13%   -0.73%     
==========================================
  Files         126      129       +3     
  Lines        4374     4593     +219     
  Branches      903      591     -312     
==========================================
+ Hits         3799     3956     +157     
- Misses        394      446      +52     
- Partials      181      191      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx marked this pull request as ready for review November 4, 2024 13:38
@akx akx enabled auto-merge (squash) November 4, 2024 13:38
@akx akx requested review from a team, hylje and dangquangdon and removed request for a team November 4, 2024 13:38
teroyks
teroyks approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pyproject.toml
@@ -59,6 +59,9 @@ target-version = "py38"
line-length = 110
preview = true

[tool.ruff.format]
quote-style = "preserve"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?
Going with uniform quote style everywhere would be preferable IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for backward compatibility (so every little change doesn’t require reformatting)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah – without it, this minor PR would've reformatted a bunch of files.

@akx akx merged commit a1d01f0 into master Nov 4, 2024
8 of 9 checks passed
@akx akx deleted the bumpsies branch November 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroyks teroyks teroyks approved these changes

@hylje hylje Awaiting requested review from hylje hylje was automatically assigned from valohai/dev-be

@dangquangdon dangquangdon Awaiting requested review from dangquangdon dangquangdon was automatically assigned from valohai/dev-be

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @teroyks