Skip to content

Commit

Permalink
make ubuntu-14 is now the build command
Browse files Browse the repository at this point in the history
  • Loading branch information
subins2000 committed Jan 9, 2022
1 parent e4c8916 commit 9f869a6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
build:
runs-on: ubuntu-18.04
env:
VARNAM_UPSTREAM: https://varnam.subinsb.com
VARNAM_UPSTREAM: https://varnamproject.com

steps:
- uses: actions/checkout@v2
Expand All @@ -31,7 +31,7 @@ jobs:
- name: Build GoVarnam-IBus Engine
run: |
sudo apt install libgtk-3-dev libcairo2-dev libglib2.0-dev
make ubuntu-18
make ubuntu-14
make release
- name: Archive production artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Build GoVarnam-IBus Engine
run: |
sudo apt install libgtk-3-dev libcairo2-dev libglib2.0-dev
make ubuntu-18
make ubuntu-14
make release
- name: Upload Release Binary
Expand Down
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ ubuntu-14:
$(MAKE) ibus-xml
$(MAKE) install-script

# Won't work
ubuntu-18:
go build -tags "pango_1_42,gtk_3_22,glib_2_66,cairo_1_15" -ldflags "-s -w" -o ${BIN} .
$(MAKE) ibus-xml
$(MAKE) install-script

# Won't work
ubuntu-20:
go build -ldflags "-s -w" -o ${BIN} .
$(MAKE) ibus-xml
Expand Down
14 changes: 5 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,19 @@ See instructions in website: https://varnamproject.github.io/download/linux

### Building

Install dependencies:
* Install dependencies:

```bash
sudo apt install libgtk-3-dev libcairo2-dev libglib2.0-dev
```

For Ubuntu 18.04 & others with old GTK versions, [special build params](https://github.com/gotk3/gotk3/issues/693) are required:
* Build

```
go build -tags pango_1_42,gtk_3_22 .
make ubuntu-14
```
You can achieve the above with `make ubuntu-18`. This build will be **usable in majority of GNU/Linux distributions**.

You can also compile with latest GTK version with :
```bash
go build .
```
or `make ubuntu-20`
The preferences dialog depends on GTK. The above command will build for **GTK 3.10** which means it'll work on Ubuntu 14.04 and later versions.

### Setup

Expand Down

0 comments on commit 9f869a6

Please sign in to comment.