-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate uniforms-material
theme
#1338
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 94.35% 95.05% +0.69%
==========================================
Files 200 175 -25
Lines 3314 2892 -422
Branches 895 763 -132
==========================================
- Hits 3127 2749 -378
+ Misses 70 59 -11
+ Partials 117 84 -33 ☔ View full report in Codecov by Sentry. |
uniforms-material
theme
I wonder if we should add somewhere in the docs an admonition that this theme has been deprecated. |
@kestarumper Maybe you could add it in the installation section when picking the material theme? It's probably very niche but better than nothing I suppose. |
@wadamek65, but we're getting rid of the Material tab button fully (this is because we're deleting all dependencies such as styles, etc). |
@kestarumper Then another option would be modifying the README in the package itself, so at least it will be shown on the npm page of the package. |
@wadamek65 well, we're deleting the README too 😅. |
@kestarumper Then I'm out of ideas 😖 |
@kestarumper We can release the last version with deprecation info and then remove the package, so in the history, there will be a readme with a message. |
conflict to fix |
946faf6
Deprecating the Material theme, as mentioned in this issue (#1315).
skipTestIf
from test suites