-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/validate-apps #250
base: master
Are you sure you want to change the base?
chore/validate-apps #250
Conversation
@claytonneal I believe there is a validation in the validate.ts file: https://github.com/vechain/app-hub/blob/master/scripts/validate.ts#L110 |
How about make it a scheduled workflow? I will change the script to check all apps then report all errors. |
If I am remembering correctly, one app used cloudflare and checkLink reports error but it works at the browser level, maybe that need extra confirm by human. |
script updated #252 |
with: | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: | |
fetch-depth: 0 |
validate link does not require full history
run: npm run validate:links | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: npm run validate:links | |
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
run: npm run validate:link |
validate link does not need a gh token, PR mode needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks tony!
@claytonneal this issue is super cool! Cant want to see it in prod ;) |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Add script and workflow to check if apps are returning http 404/500 etc