Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #12

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Oct 18, 2024

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

Add support for PHP 8.4, and run workflows on that version.

@acelaya
Copy link
Contributor Author

acelaya commented Oct 18, 2024

Running psalm on PHP 8.4 seems to fail, and I just realized they do not officially support that version yet.

For tests it makes sense to run workflows explicitly for all supported PHP versions, but perhaps you would consider running workflows for static analysis and code checks on a single PHP version?

Otherwise I'm fine keeping this open until psalm supports PHP 8.4 and then update this.

@veewee
Copy link
Owner

veewee commented Oct 19, 2024

Thanks @acelaya

The changes look fine.

It seems that this repo is still on psalm V4. Bumping to latest 5.x might solve the issue.

Would you mind looking into this? I'm also fine with just merging this one and look at it later.

@acelaya
Copy link
Contributor Author

acelaya commented Oct 19, 2024

Would you mind looking into this?

I can do that. I see the project has a few tools tracked in the tools folder. Do you usually update those manually, or are you using something to handle those dependencies?

@acelaya
Copy link
Contributor Author

acelaya commented Oct 19, 2024

I downloaded the latest psalm.phar, and it doesn't seem to solve the problem, as the system check still fails.

Additionally, checks fail now with the rest of PHP versions for what I think are probably some changes between versions 4 and 5.

I'll revert this, as it's probably worth tackling the psalm update on its own. You can see the workflow run here https://github.com/veewee/composer-run-parallel/actions/runs/11415978568?pr=12

@veewee
Copy link
Owner

veewee commented Oct 21, 2024

Thanks

@veewee veewee merged commit 24b9244 into veewee:main Oct 21, 2024
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants