-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): modify docs navigation hrefs for compatibility with offline documentation #9254
base: main
Are you sure you want to change the base?
Conversation
…entation browsing
…ing without redirects
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
36730a7
to
7e01381
Compare
site/_data/versions.yml
Outdated
@@ -0,0 +1,4 @@ | |||
vega: 5.27.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generate this at build time so it doesn't need to be in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, would it make sense for me to add this file to the .gitignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but make sure it doesn't cause issues with the page build.
7e01381
to
5930cc3
Compare
WIP - A modern redo of #7642
Motivation
New Changes
Old Changes
Testing