-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center tokens. #69
Open
neerajbaid
wants to merge
12
commits into
venmo:master
Choose a base branch
from
neerajbaid:nb/centered
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−40
Open
Center tokens. #69
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3601e82
Position tokens properly.
ad089cf
Update currentX so inputTextField repositions properly for VENTokenFi…
0753702
VENTokenFieldAlignment now mirrors NSTextAlignment. collapsedLabel te…
c6994e4
Fix assignment of *currentY in realignRowOfTokens:. Remove VENTokenFi…
72746d4
Use placeholder token for input text field positioning. Live update t…
debd011
Use placeholderTextLabel.
8c6245f
Insert placeholderTextLabel below inputTextField.
dbeda17
Remove now unused minInputWidth property.
babd933
Readd but deprecate minInputWidth.
41fb5f2
Rename alignment to tokenAlignment to better mirror UITextField textA…
1f615c1
Pull out token frame generator into own method.
b7101d8
Move inputTextField to edge of placeholderTextLabel like native cente…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyboardInputShouldDelete
seemed to preventtextField:shouldChangeCharactersInRange:replacementString
from being called on backspaces (and possibly other unknown side effects).deleteBackward
doesn't seem to have the same limitation.