Fix #68 #77
Open
Fix #68 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found where is the problem. It's wrong to use parent.display_name to build child name, because in case of localised .xib or .storyboard files localised version could be an .strings file as described in issue.
I'm not a Ruby developer. I didn't understand the full meaning of 'parent' and 'child' (self) here and meaning of their properties. I've found the roots of the problem here with debugger and this commit fixed it. My tests didn't reveal any new problems.
Maybe there is more suitable way to build correct path here. Please, consider it before accepting this pull request :)