feat: add filename flag to change built filename
#643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are some test errors. Unfortunately, I wasn't able to get testing working on a clean install of the repository. I'll look into getting tests to work locally so I can move forward with the PR. |
|
would love to see this |
justalemon
added a commit
to justalemon/VersionPatcher
that referenced
this pull request
Jul 29, 2023
|
pity this PR was never merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--filename(or-f) option to the NCC CLI to change the name of the emitted file from the standardindex.c|jsname.fixes: #539, #492