Make it possible to infer the fetcher's key #2067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inference function
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de625fd:
|
|
I think we might still need to keep this overload here for compatibility for now #1640 (comment) |
|
Thanks for the quick feedback. I'll check it out! |
|
I understand the compatibility concerns but why can't it be changed in 2.0.0-beta already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am using passing objects feature (https://swr.vercel.app/docs/arguments#passing-objects) like this.
Unfortunately, This obviously leads to incorrect execution.
But you won't know until execute project.
because this fetcher infers the type as a
bare fetcher, it shows no error information.but, enable key inference with this update,
can be corrected correctly
I looked at swr2 (also 1.3), If only a fetcher and a key exist, there is no need to infer that it is a
bare fetcher.so I think it would be better to inform the user that this is an incorrect usage.
Please consider this change.
thank you for read!