-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gfp computation #197
Open
vferat
wants to merge
5
commits into
main
Choose a base branch
from
dev-gfp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix gfp computation #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
34
to
45
def _std(): | ||
def compute_std(data): | ||
return np.std(data, axis=0) | ||
|
||
return compute_std | ||
|
||
|
||
def _rms(): | ||
def compute_rms(data): | ||
return np.sqrt(np.mean(data**2, axis=0)) | ||
|
||
return compute_rms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to nest here and you could use a dict to store the GFP functions per channel type:
_GFP_FUNC: dict[str, Callable] = {
"eeg": lambda x: np.std(x, axis=0),
"grad": lambda x: np.sqrt(np.mean(x**2, axis=0)),
"mag": lambda x: np.sqrt(np.mean(x**2, axis=0)),
}
# and later to use it:
_check_value(ch_type, _GFP_FUNC, "ch_type")
gfp = _GFP_FUNC[ch_type](data)
It removes the additional private functions and the nesting of function within, and removes the if/else logic on channel types.
for more information, see https://pre-commit.ci
Co-Authored-By: Mathieu Scheltienne <[email protected]>
for more information, see https://pre-commit.ci
This is good to merge? @vferat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #160 and #195, introduces changes to the Global Field Power (GFP) computation based on the selected channel type.
When the channel type is
eeg
, the GFP is now computed using the standard deviation (std).When the channel type is
grad
ormag
, the GFP is computed using the root mean square (rms).