-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2552: Add images user journey #2991
Conversation
Overall readability score: 53.03 (🟢 +0.01)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Based on Eliot's feedback yesterday, let's split this into multiple one that covers image capture and filtering and one that covers image capture, datasets labeling and ml. And let's exclude alerts today. |
Does that mean we duplicate the image capture content onto both? Maybe with an includes? |
@JessamyT you can now rebase |
docs/use-cases/image-data.md
Outdated
|
||
{{< table >}} | ||
{{< tablestep >}} | ||
{{<imgproc src="/icons/components/camera.svg" class="fill alignleft" style="max-width: 150px" declaredimensions=true alt="configure a camera component">}} | ||
**1. Configure a camera** | ||
**1. Configure a camera [_(i)_](/components/camera/)** | ||
|
||
First, [create a machine](/cloud/machines/#add-a-new-machine) if you haven't yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the creating a machine as a prerequisite instead please as with the sensor journeys: https://github.com/viamrobotics/docs/pull/2986/files#commit-suggestions.
docs/use-cases/deploy-ml.md
Outdated
|
||
Start by collecting images from your cameras with the [data management service](/services/data/). | ||
You can [view the data](/services/data/view/) on the **Data tab**. | ||
{{% alert title="Tip" color="tip" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this under the steps for creating and labeling data. You might need to adjust the text a little but I think since it's more of an aside anyway it can go at the bottom of this segment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though they'd need to do this during this step, before collecting the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they end up getting to the end of this and then having a few images that don't have the label I think that's ok. So yes
Co-authored-by: Naomi Pentrel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things, but also this isn't merge ready. Do you want to wait until my PR merges and then change the little info icons? You may also be able to copy the layout changes into your PR so you're not blocked
docs/use-cases/deploy-ml.md
Outdated
|
||
Start by collecting images from your cameras with the [data management service](/services/data/). | ||
You can [view the data](/services/data/view/) on the **Data tab**. | ||
{{% alert title="Tip" color="tip" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they end up getting to the end of this and then having a few images that don't have the label I think that's ok. So yes
Co-authored-by: Naomi Pentrel <[email protected]>
3f3472d
to
1f36062
Compare
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2991 |
Merging for now so we can test more easily |
Notes:
Links: https://docs-test.viam.dev/2991/use-cases/image-data/
https://docs-test.viam.dev/2991/use-cases/deploy-ml/