Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2949: Fix mismapped methods #3651

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Nov 2, 2024

  • Fixes mixup of value vs name, ex. AnalogByName != analogReaderValue, same issue with interrupt.
  • The actual proto names for "Write," "Read," and "Value" are WriteAnalog, ReadAnalogReader and GetDigitalInterruptValue, and using those consistently may help avoid the above confusion ^ in the future
  • Don't merge until https://viaminc.slack.com/archives/C0653ULNNAX/p1730506244310229 is resolved
  • Move GetGeometries further down the page because it's not board-specific and thus belongs at the bottom near the other inherited methods

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 2, 2024
@viambot
Copy link
Member

viambot commented Nov 5, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3651

@JessamyT JessamyT merged commit d88dc76 into viamrobotics:main Nov 5, 2024
9 checks passed
@JessamyT JessamyT deleted the 2949boardqa branch November 5, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants