Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger sync page #3652

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Update trigger sync page #3652

merged 4 commits into from
Nov 5, 2024

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Nov 4, 2024

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 4, 2024
@@ -28,7 +28,7 @@ You can use it as the basis of your own custom logic.

{{% alert title="In this page" color="tip" %}}

1. [Use the `CreateShouldSyncReading` function to enable sync](#use-the-createshouldsyncreading-function-to-enable-sync)
1. [Return `should_sync` as a reading from a sensor](#return-should_sync-as-a-reading-from-a-sensor)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If builtin data manager is configured with a sync sensor, data manager will only sync on the sync interval if the syncs sensor's Readings method returns a successful response and that response has a "should_sync" key
in it with a value of true.

Otherwise, a builtin data manager will not sync on the sync interval.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted the descriptions below a bit - what you commented on is really only a table of contents - so not really a place to explain this further.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the headers if you have a better suggestion?
Thanks for the code changes - that's a lot cleaner

docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Outdated Show resolved Hide resolved
docs/how-tos/trigger-sync.md Show resolved Hide resolved
@nicksanford
Copy link
Member

@npentrel
Copy link
Collaborator Author

npentrel commented Nov 4, 2024

Screenshot 2024-11-04 at 17 50 05
highlighting for the relevant lines - hadn't updated that for your changes

@viambot
Copy link
Member

viambot commented Nov 4, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3652

@npentrel npentrel requested a review from nicksanford November 4, 2024 17:27
@npentrel npentrel merged commit 75cf2e4 into viamrobotics:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants