Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3147: Use resource-level logging for Python modules #3736

Merged
merged 3 commits into from
Dec 10, 2024
Merged

DOCS-3147: Use resource-level logging for Python modules #3736

merged 3 commits into from
Dec 10, 2024

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Dec 6, 2024

No description provided.

@JessamyT JessamyT requested a review from mcvella December 6, 2024 02:45
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Dec 6, 2024
npentrel
npentrel approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@npentrel npentrel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - was that the only occurrance of using the global logger in our docs?

@JessamyT JessamyT requested a review from stuqdog December 7, 2024 00:04
stuqdog
stuqdog approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for updating these!

@JessamyT
Copy link
Collaborator Author

JessamyT commented Dec 9, 2024 •
edited
Loading

This looks good to me - was that the only occurrance of using the global logger in our docs?

This and the sensor module page which also needs updating generally (so not doing in this PR) were the only places where I see it for Python

@viambot
Copy link
Member

viambot commented Dec 9, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3736

@JessamyT JessamyT merged commit 24e799f into viamrobotics:main Dec 10, 2024
9 checks passed
@JessamyT JessamyT deleted the 3147logging branch December 10, 2024 18:53
@github-actions GitHub Actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog approved these changes

@npentrel npentrel npentrel approved these changes

@mcvella mcvella Awaiting requested review from mcvella

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JessamyT @viambot @npentrel @stuqdog