fix: retry for jobs

vicholp · Dec 19, 2023 · ab8d4c8 · ab8d4c8
1 parent 152e337
commit ab8d4c8
Show file tree

Hide file tree

Showing 6 changed files with 62 additions and 5 deletions.
diff --git a/app/Jobs/Art/MinimizeArtJob.php b/app/Jobs/Art/MinimizeArtJob.php
@@ -16,13 +16,24 @@ class MinimizeArtJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 3;
+
     /**
      * Create a new job instance.
      *
      * @return void
      */
     public function __construct(
-        private string $source_path, private string $target_path, private int $height, private int $width, private int $quality = 80
+        private string $sourcePath,
+        private string $targetPath,
+        private int $height,
+        private int $width,
+        private int $quality = 80
     ) {
         //
     }
@@ -34,6 +45,12 @@ public function __construct(
      */
     public function handle()
     {
-        (new ArtService())->minimizeArt($this->source_path, $this->target_path, $this->height, $this->width, $this->quality);
+        (new ArtService())->minimizeArt(
+            $this->sourcePath,
+            $this->targetPath,
+            $this->height,
+            $this->width,
+            $this->quality
+        );
     }
 }
diff --git a/app/Jobs/Art/SyncArtJob.php b/app/Jobs/Art/SyncArtJob.php
@@ -19,6 +19,13 @@ class SyncArtJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 3;
+
     /**
      * Create a new job instance.
      *

diff --git a/app/Jobs/Synchronization/CheckServerTracksJob.php b/app/Jobs/Synchronization/CheckServerTracksJob.php
@@ -17,6 +17,13 @@ class CheckServerTracksJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 3;
+
     /**
      * Create a new job instance.
      */

diff --git a/app/Jobs/Synchronization/SyncAlbumFromBeetsJob.php b/app/Jobs/Synchronization/SyncAlbumFromBeetsJob.php
@@ -20,15 +20,22 @@ class SyncAlbumFromBeetsJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 3;
+
     /**
      * Create a new job instance.
      *
      * @return void
      */
     public function __construct(
         private Server $server,
-        private string $mb_id,
-        private string $beets_album_id,
+        private string $mbId,
+        private string $beetsAlbumId,
     ) {
         //
     }
@@ -46,6 +53,11 @@ public function handle()
 
         $beetsService = new BeetsService($this->server);
 
-        (new SynchronizationService())->syncAlbumFromBeets($beetsService, $this->server, $this->mb_id, $this->beets_album_id);
+        (new SynchronizationService())->syncAlbumFromBeets(
+            $beetsService,
+            $this->server,
+            $this->mbId,
+            $this->beetsAlbumId
+        );
     }
 }
diff --git a/app/Jobs/Synchronization/SyncReleaseJob.php b/app/Jobs/Synchronization/SyncReleaseJob.php
@@ -16,6 +16,13 @@ class SyncReleaseJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 3;
+
     /**
      * Create a new job instance.
      *

diff --git a/app/Jobs/Synchronization/SyncServerJob.php b/app/Jobs/Synchronization/SyncServerJob.php
@@ -17,6 +17,13 @@ class SyncServerJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    /**
+     * The number of times the job may be attempted.
+     *
+     * @var int
+     */
+    public $tries = 5;
+
     /**
      * Create a new job instance.
      *